nsxiv/.woodpecker, branch master

Move uncritical files into `etc/` (#350)

2022-08-09T14:21:52Z

This is mainly just to reduce the amount of files in the project root. The criteria of what gets into `etc/` are the following: * The file should not be necessary for building nsxiv. This excludes the `icon/*` stuff since that's needed by `window.c`. * The file shouldn't have any valid reason to stay in the project root. This excludes things like `README.md`, `.gitignore` etc. Reviewed-on: https://codeberg.org/nsxiv/nsxiv/pulls/350 Reviewed-by: explosion-mental

[ci]: fix failure (#348)

2022-07-29T01:37:40Z

* install unversioned `llvm` so that it pulls the latest one. * disable `uninitvar` check on cppcheck as it catches some false positives and gcc/clang/clang-tidy are good at catching uninitialized variables already. Reviewed-on: https://codeberg.org/nsxiv/nsxiv/pulls/348 Reviewed-by: explosion-mental

[ci]: use `git ls-files` for spellchecking (#345)

2022-07-27T06:57:50Z

excluding the `.png` icons. this also fixes the wrong `.patch` and `.diff` extensions checks. no clue why we were trying to find `.patch` and `.diff` to begin with. i think i probably copy pasted the command i tested on nsxiv-extra repo or somewhere else without changing the extensions to `.c` and `.h`. Reviewed-on: https://codeberg.org/nsxiv/nsxiv/pulls/345

fix: -Wsign-compare warnings (#336)

2022-07-15T20:46:23Z

mixing signed and unsigned types in comparison can end up having unintended results. for example: if (-1 < 1U) printf("true\n"); else printf("false\n"); previously we silenced these warnings, instead just fix them properly via necessary casting, and in cases where the value cannot be negative (e.g width/height members) make them unsigned. Reviewed-on: https://codeberg.org/nsxiv/nsxiv/pulls/336 Reviewed-by: explosion-mental

sort and group includes

2022-06-28T19:28:06Z

* includes are sorted alphabetically * their grouping and layout is the following: - nsxiv.h will be the first include - followed by any internal headers (e.g "commands.h" "config.h") - followed by system headers ( etc) - followed by third party headers (X.h libwebp etc) * also add `llvm-include-order` check to clang-tidy so that it can catch unsorted includes during CI.

[ci]: check for typos via codespell (#326)

2022-06-27T08:47:14Z

also fix any found issues. Reviewed-on: https://codeberg.org/nsxiv/nsxiv/pulls/326 Reviewed-by: Berke Kocaoğlu

[ci]: skip the pipeline entirely if branch isn't master

2022-06-25T06:27:01Z

currently, it will clone the repo and then skip the step. this is wasteful, instead skip the pipeline entirely.

[ci]: suppress some cppcheck warnings

2022-06-25T06:27:01Z

cppcheck warns about passing a plain NULL to construct_argv() main.c:254:36: portability: Passing NULL after the last typed argument to a variadic function leads to undefined behaviour. [varFuncNullUB] fidx, fcnt, w, h, z, NULL); in our case, POSIX mandates `NULL` to be defined as `(void *)0` rather than a plain `0` [0]. and void pointers are required to have the same representation and size as char pointers [1]. so this is not an issue we need to worry about. [0]: https://pubs.opengroup.org/onlinepubs/9699919799/basedefs/stddef.h.html#tag_13_47 [1]: https://port70.net/~nsz/c/c99/n1256.html#6.2.5p27

[ci]: use cppcheck and clang-tidy for static analysis

2022-06-25T06:27:01Z

add codeberg ci and cleanup github one (#311)

2022-06-16T03:08:09Z

- apt-get is slow, takes up ~1m40s just to install deps, fix it by not using it. instead use alpine linux for codeberg ci, which brings build time down to 25s. - And since alpine uses musl, it's probably a good idea to use it on our ci since it might catch us using any glibc extensions. The github ci can keep using ubuntu. - remove duplication of CFLAGS by having it on a separate file instead. - remove pull_request from github ci since we no longer accept PRs there. Closes: https://codeberg.org/nsxiv/nsxiv/issues/307 Reviewed-on: https://codeberg.org/nsxiv/nsxiv/pulls/311 Reviewed-by: Berke Kocaoğlu Reviewed-by: TAAPArthur