nsxiv/thumbs.c, branch master

apply clang-format

2023-03-11T12:37:04Z

minus the bogus changes Co-authored-by: Berke Kocaoğlu

update copyright year

2023-01-28T10:29:36Z

use assertions instead of ignoring bogus arguments (#406)

2023-01-28T10:27:40Z

instead of silently ignoring bogus arguments (i.e programming errors), which can make debugging harder, it's better to assert them so that they get caught faster in debug builds. Reviewed-on: https://codeberg.org/nsxiv/nsxiv/pulls/406 Reviewed-by: explosion-mental

code-style: misc changes (#374)

2022-10-19T12:46:22Z

* ensure static variables comes after non-static ones * remove depreciated DATA32 type * prefer `sizeof(expression)` over `sizeof(Type)`. * silence a -Wsign warning * {gif,webp} loader: use a pointer to reduce code-noise * gif loader: allocate in one place Reviewed-on: https://codeberg.org/nsxiv/nsxiv/pulls/374 Reviewed-by: TAAPArthur

code-style: don't indent switch cases (#358)

2022-08-16T08:54:31Z

The suckless coding style [^0] and the linux coding style [^1] both recommends not indenting switch cases. And it helps out people with lower resolution monitors. [^0]: https://suckless.org/coding_style/ [^1]: https://www.kernel.org/doc/html/v5.10/process/coding-style.html#indentation Co-authored-by: explosion-mental Reviewed-on: https://codeberg.org/nsxiv/nsxiv/pulls/358 Reviewed-by: NRK Co-authored-by: explosion-mental Co-committed-by: explosion-mental

fix: -Wsign-compare warnings (#336)

2022-07-15T20:46:23Z

mixing signed and unsigned types in comparison can end up having unintended results. for example: if (-1 < 1U) printf("true\n"); else printf("false\n"); previously we silenced these warnings, instead just fix them properly via necessary casting, and in cases where the value cannot be negative (e.g width/height members) make them unsigned. Reviewed-on: https://codeberg.org/nsxiv/nsxiv/pulls/336 Reviewed-by: explosion-mental

code-style: cleanup includes

2022-06-28T19:28:06Z

* rm unused include * move to main.c, it's the only file that needs it. * move TV_* macros to main.c * let *.c files explicitly include what they need instead of including them at nsxiv.h

fix: don't use reserved identifiers

2022-06-25T06:27:01Z

identifiers beginning with an underscore is reserved by the C standard.

r_mkdir: don't truncate the path on error (#322)

2022-06-22T03:05:03Z

currently, in case of error, r_mkdir will leave the path at a truncated state. a7d39b0ab8 is the commit that introduced this change, and in it the error printing is moved from r_mkdir to the caller, which makes me think it was probably intentional. make it so that the function itself prints the error/warning message and returns the path back to the caller unharmed. Reviewed-on: https://codeberg.org/nsxiv/nsxiv/pulls/322 Reviewed-by: Berke Kocaoğlu Reviewed-by: TAAPArthur

reduce calls to win-title

2022-06-02T08:09:51Z

rather than calling the script unconditionally per redraw, we now have a `title_dirty` flag and keep track of when any of the relavent information changes. Co-authored-by: Arthur Williams Partially fixes: https://github.com/nsxiv/nsxiv/issues/258