Krolyxon
Commit 7e7eaf0

Branches

Refs →

nsxiv7e7eaf0

fix: memory leak due to not destroying XrmDatabase (#134)

Author
N-R-K
Date
2021-10-28 07:57 +0600
Committer
GitHub · 2021-10-28 01:57 +0000
Parent
5775457
Commit
7e7eaf08f12d43e2eb2d425a08c5c5ad52b17bb1

+3 −2

1 file changed

  1. M window.c +3 −2
M window.c View
@@ -92,7 +92,7 @@ const char* win_res(XrmDatabase db, const char *name, const char *def)
9292 char *type;
9393 XrmValue ret;
9494
95− if (db != None &&
95+ if (db != NULL &&
9696 XrmGetResource(db, name, name, &type, &ret) &&
9797 STREQ(type, "String"))
9898 {
@@ -130,7 +130,7 @@ void win_init(win_t *win)
130130
131131 XrmInitialize();
132132 res_man = XResourceManagerString(e->dpy);
133− db = res_man != NULL ? XrmGetStringDatabase(res_man) : None;
133+ db = res_man == NULL ? NULL : XrmGetStringDatabase(res_man);
134134
135135 win_bg = win_res(db, RES_CLASS ".window.background", "white");
136136 win_fg = win_res(db, RES_CLASS ".window.foreground", "black");
@@ -158,6 +158,7 @@ void win_init(win_t *win)
158158 win->bar.h = options->hide_bar ? 0 : barheight;
159159 #endif /* HAVE_LIBFONTS */
160160
161+ XrmDestroyDatabase(db);
161162 INIT_ATOM_(WM_DELETE_WINDOW);
162163 INIT_ATOM_(_NET_WM_NAME);
163164 INIT_ATOM_(_NET_WM_ICON_NAME);